Note: updated with a substitution for UnsafeRefArrayAccess / ignoring it could yield to segfaults as the field offset couldn't be computed (it uses a non-classic Unsafe access pattern).

Note: updated with a substitution for UnsafeRefArrayAccess / ignoring it could yield to segfaults as the field offset couldn't be computed (it uses a non-classic Unsafe access pattern).

@jponge I had a look at org.graalvm.nativeimage.hosted.Feature.BeforeAnalysisAccess#registerAsUnsafeAccessed and it looks like it's mostly being used by Truffle.

Unsafe accesses seem to be automatically detected and registered by GraalVM, e.g. https://github.com/oracle/graal/blob/c95781d03099ebd1dad495ac1fefca863178b358/substratevm/src/com.oracle.graal.pointsto/src/com/oracle/graal/pointsto/flow/MethodTypeFlowBuilder.java#L304

Does this mean we can follow this pattern and completely remove UnsafeAccessedFieldBuildItems in favor of RecomputeFieldValue?

@jponge please have a look at #39831 as well before merging this. It makes the mutiny changes redundant.

Does this mean we can follow this pattern and completely remove UnsafeAccessedFieldBuildItems in favor of RecomputeFieldValue?

AFAIK most Unsafe patterns indeed get detected now, but one such as UnsafeRefArrayAccess.REF_ELEMENT_SHIFT is not, hence the need for either a substitution or a UnsafeAccessedFieldBuildItem that does not involved build-time init

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b35ae00.

Failing Jobs

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: integration-tests/grpc-hibernate-reactive 

📦 integration-tests/grpc-hibernate-reactive

✖ Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-grpc-hibernate-reactive: Failed to build quarkus application

Flaky tests - Develocity

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/maven

✖ io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - History

• Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils.waitForNextCompletion(TestModeContinuousTestingMavenTestUtils.java:49)
	at io.quarkus.maven.it.LaunchMojoTestBase.testThatTheTestsAreReRunMultiModule(LaunchMojoTestBase.java:56)

✖ io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - History

• Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils.waitForNextCompletion(TestModeContinuousTestingMavenTestUtils.java:49)
	at io.quarkus.maven.it.LaunchMojoTestBase.testThatTheTestsAreReRunMultiModule(LaunchMojoTestBase.java:56)

Does this mean we can follow this pattern and completely remove UnsafeAccessedFieldBuildItems in favor of RecomputeFieldValue?

I would be in favor of this. The UnsafeAccessedFieldBuildItems leads to loading the class at build time (and so run the initialization of the class) which can lead to issues if this class must be runtime only. I wonder if we can workaround this using "re-initialize at runtime".

The UnsafeAccessedFieldBuildItems leads to loading the class at build time (and so run the initialization of the class) which can lead to issues if this class must be runtime only. I wonder if we can workaround this using "re-initialize at runtime".

FYI I have a fix for this behavior in #39831, but it's still WIP since it triggers other issues.

One down! 🤣

🎉

should this be backported to 3.8.4 as well? since vertx and netty were also upgraded there

Makes sense

Yes please!

@jponge I don't think this can be backported as is to 3.9 and 3.8.

At least the commit with JCTools is causing issues as I think you are only using this with latest Mutiny?

Error: Substitution target for io.quarkus.mutiny.runtime.Target_org_jctools_util_UnsafeRefArrayAccess is not loaded. Use field `onlyWith` in the `TargetClass` annotation to make substitution only active when needed.
com.oracle.svm.core.util.UserError$UserException: Substitution target for io.quarkus.mutiny.runtime.Target_org_jctools_util_UnsafeRefArrayAccess is not loaded. Use field `onlyWith` in the `TargetClass` annotation to make substitution only active when needed.
	at org.graalvm.nativeimage.builder/com.oracle.svm.core.util.UserError.abort(UserError.java:73)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.findTargetClass(AnnotationSubstitutionProcessor.java:1074)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.handleClass(AnnotationSubstitutionProcessor.java:373)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.init(AnnotationSubstitutionProcessor.java:351)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGenerator.createAnnotationSubstitutionProcessor(NativeImageGenerator.java:1029)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGenerator.setupNativeImage(NativeImageGenerator.java:907)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:590)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGenerator.run(NativeImageGenerator.java:550)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGeneratorRunner.buildImage(NativeImageGeneratorRunner.java:539)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGeneratorRunner.build(NativeImageGeneratorRunner.java:721)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGeneratorRunner.start(NativeImageGeneratorRunner.java:143)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGeneratorRunner.main(NativeImageGeneratorRunner.java:98)

(discussed offline - yes 👍 )

For 3.9 and 3.8, only the Netty changes should be backported.

See this commit: d2673c8